Select multiple messages in chat for forwarding & deletion

[farooqkz]

This PR aims to implement selecting multiple messages for forwarding and deleting. Reviews are welcome after christmas :)

i know, this is a draft, bit some comments on testing:

* the "forward/delete" bar needs a "cancel" or "X" button (i think, an "X" to the very right would be pretty straight forward)

* it is not possible to select images as this enlages images - every tap should just select in select mode. at best, we should also handle taps in the backgound left/right of the bubbles (esp. if we hilite messages using a background color)

* if not too hard, i'd prefer to have the "forward/delete bar" at the bottom, replacing the input bar during select mode

otherwise, this is a really BIG enhancement - in comparable few lines of code :) great!

• We've got a cancel button now
• Fixed
• We should get votes for that

this would solve one part of #2892 (that issue is about multi select in chatlist, message list and gallery)

[adzialocha]

I can see some nice patterns here with dedicated components and reducer logic for the selection logic.

As written above I'd suggest to factor out the state as well into an own context, to avoid prop drilling and making Message and MessageList more complex.

You already have some code isolation in place and we could go even further. I'd suggest to create a new folder and move a context implementation, your new components, the reducer and maybe even the CSS module there to make it all represent the "multi select" feature, completly independent from the rest.

[adzialocha]

It would be nice to use CSS modules here instead if possible

[adzialocha]

MessageList and Message get quite many new props here which I wouldn't see directly as part of the message component itself.

Maybe we can introduce a context here instead to manage the selection state for messages? The context lives in the currently displayed chat and every message can consume the state of the context to understand if it is selected or not.

I've seen you already have a nice reducer. With the context representing the state and the reducer changing it we can have a nice isolated logic. All of this can be moved into own files.

[adzialocha]

Let me know if you need any help with my suggested changes! Also I've changed the target branch to the button refactor one as this branch includes these changes as well, hope that's okay.

[Simon-Laux]

does not work for me or I don't understand how to do it, lets put it into draft state again until it is mergeable.

[farooqkz]

does not work for me or I don't understand how to do it, lets put it into draft state again until it is mergeable.

I've began to use Contexts thanks to adz. You can omit my last commit to see the working version with props drilling.

[farooqkz]

@adz, I have difficulty implementing your suggestion. Some hints?

On second thought, please give me some more days.

[farooqkz]

@adz, I have difficulty implementing your suggestion. Some hints?

On second thought, please give me some more days.

Okay I'm stuck, man!

[adz]

Different adz I think. Interesting project though.

[adzialocha]

This is a really nice feature and I'd love to see it getting released, maybe in v1.46. @farooqkz we can look at it together whenever you are ready in the next weeks, I'm happy to make some direct code suggestions as well if that's fine with you

[hpk42]

Discussed with nico and farooq -- putting this into project resurrection for when the time comes!