Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"add second device" dialog improvements #3748

Merged
merged 4 commits into from
Apr 8, 2024
Merged

"add second device" dialog improvements #3748

merged 4 commits into from
Apr 8, 2024

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Apr 4, 2024

  • hide steps when transfering
  • opinionated style changes - center progressbar on preparing (IMO looks better centered when switching to qr code) - while transfering make the bar take the whole width of the dialog (centered looked weird (how much width should it have); with a larger bar you can see more progress when you have a slow transfer with a big account)

fixes #3742

After Screenshots:

  • before qr code is shown: Bildschirmfoto 2024-04-04 um 18 38 29
  • after qr code was scanned by other device: Bildschirmfoto 2024-04-04 um 18 38 58

- center progressbar on preparing (IMO looks better centered when switching to qr code)
- while transfering make the bar take the whole width of the dialog (centered looked weird (how much width should it have); with a larger bar you can see more progress when you have a slow transfer with a big account)
@Simon-Laux Simon-Laux requested review from adzialocha and r10s April 4, 2024 16:55
@Simon-Laux Simon-Laux self-assigned this Apr 4, 2024
@Simon-Laux Simon-Laux merged commit 0954b90 into master Apr 8, 2024
4 of 6 checks passed
@Simon-Laux Simon-Laux deleted the simon/i3742 branch April 8, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

hide "add second device" instructions when transfer has started
2 participants