blueprintjs removal part1 #3857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add icon to ContextMenuItem and render those * use our ContextMenu for AttachmentMenu * replace BlueprintJS components with ours for chat navbar and attachment menu
* replace BlueprintJS components with our own implementation
|
this is not meant for inclusion for 1.46 release, is it?
…On Fri, May 24, 2024 at 12:24 -0700, Max Philippov wrote:
- replace all occurrences of BlueprintJS Icon, Button, Radio, RadioGroup, Collapse components
#3811 approval is required to merge this
You can view, comment on, or merge this pull request online at:
#3857
-- Commit Summary --
* Our own icons for ContextMenu, chat navbar
* Replace BlueprintJS Button, Icon, Radio, Collapse
-- File Changes --
M CHANGELOG.md (5)
A images/icons/chats.svg (1)
A images/icons/chevron-left.svg (1)
A images/icons/chevron-right.svg (1)
A images/icons/map.svg (1)
A images/icons/paperclip.svg (1)
A images/icons/phone.svg (1)
A images/icons/upload-file.svg (1)
M scss/_global.scss (1)
M scss/components/_radios.scss (2)
M scss/composer/_composer.scss (25)
M scss/main_screen/_navbar_wrapper.scss (14)
M scss/misc/_context_menu.scss (14)
M src/renderer/components/Button/index.tsx (3)
M src/renderer/components/Button/style.module.scss (9)
A src/renderer/components/Collapse/index.tsx (49)
M src/renderer/components/ContextMenu.tsx (5)
M src/renderer/components/Icon/index.tsx (31)
M src/renderer/components/Icon/styles.module.scss (12)
M src/renderer/components/InputTransferKey.tsx (5)
M src/renderer/components/LoginForm.tsx (2)
M src/renderer/components/SearchInput/styles.module.scss (3)
M src/renderer/components/Settings/Appearance.tsx (2)
M src/renderer/components/SmallSelectDialog.tsx (17)
M src/renderer/components/composer/menuAttachment.tsx (104)
M src/renderer/components/contact/ContactListItem.tsx (2)
M src/renderer/components/dialogs/DisappearingMessages.tsx (9)
M src/renderer/components/dialogs/FullscreenAvatar.tsx (5)
M src/renderer/components/dialogs/FullscreenMedia.tsx (5)
M src/renderer/components/screens/MainScreen.tsx (50)
M test/testcafe/messagelist_tests.ts (2)
M themes/_themebase.scss (4)
-- Patch Links --
https://github.com/deltachat/deltachat-desktop/pull/3857.patch
https://github.com/deltachat/deltachat-desktop/pull/3857.diff
--
Reply to this email directly or view it on GitHub:
#3857
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
|
What is status of this? Ready for review? |
I'll push today-tomorrow an updated version, maybe as a separate pr, I didn't touch the Gallery, but removed everything else (including dependency from package.json, so you could probably test your changes against my branch) |
Not touching Gallery is alright as I have another PR for that. |
|
Closing this one in favor of a more complete effort: #4006 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3811 approval is required to merge this