refactor: safer types #3993
Merged
refactor: safer types #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/safer-types-refactor
branch
2 times, most recently
from
fe530e4 to
7ec120d
Compare
To avoid issues like #3990 This ensures that the type and the array always have the same keys However, simply adding an extra property on `SettingsValues` will not cause errors, it will simply keep the `SettingsStoreState` type unchanged. But any runtime changes (e.g. adding or accessing a property without also adding it to the array, or vice versa) will be caught.
WofWca
force-pushed
the
wofwca/safer-types-refactor
branch
from
7ec120d to
22526ae
Compare
Simon-Laux
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid issues like #3990