fix: more <InfiniteLoader> fixes
#4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
added
bug
WofWca
force-pushed
the
wofwca/infinite-loader-fixes
branch
from
269d4e8 to
886dbdb
Compare
it would show up after you scroll Reproduction: 1. Have no chats in archive 2. Restart Delta Chat 3. Archive a chat A skeleton will show at the start of the list. After you scroll, "archive" will show up there Same issue as - #3921 - #3208 The removed `useEffect`s are not needed anymore, since `InfiniteLoader` now (hopefully) takes care of all the `load<something>()` operations
Simon-Laux
force-pushed
the
wofwca/infinite-loader-fixes
branch
from
886dbdb to
b94398d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits
Please verify that the old skeleton issues didn't come back after the removal of those
useEffects.fixes #3921
fixes #3208