Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: a way to grant permissions to webxdcs #4008

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Sep 10, 2024

  1. refactor: modify menu insted of rebuilding it

    https://www.electronjs.org/docs/latest/api/menu#menugetapplicationmenu :
    > Note: The returned Menu instance doesn't support dynamic addition
    > or removal of menu items. Instance properties
    > can still be dynamically modified.
    
    Also https://stackoverflow.com/questions/47756822/change-electrons-menu-items-status-dynamically/47761652#47761652
    
    I checked and it works
    WofWca authored and Simon-Laux committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e1cd594 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8c8357 View commit details
    Browse the repository at this point in the history
  3. improvement: improve webxdc permission handling

    - more possible permissions to grant
    - don't show permissions that were never checked or requested
    - security: check `requestingUrl` origin just in case
    - adjust log text
    WofWca authored and Simon-Laux committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ef54af7 View commit details
    Browse the repository at this point in the history