feat: paste invite link to search to add contact #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
handle-invite-link-from-search-input
branch
3 times, most recently
from
e22d05e to
e87a8d4
Compare
Simon-Laux
approved these changes
Jul 21, 2024
Comment on lines
+131
to
+132
| // Perhaps we could also parse username from the link | ||
| // and put it into `subText`. |
There was a problem hiding this comment.
I think rpc.checkQr should work for that, like it gets the name for the confirmation dialog when it asks you wether you want to chat with <Name>
There was a problem hiding this comment.
This could be improved in another PR. It would be nice to show both, the displayname & the mail address since the random testrun.org addresses are usually not known, only the displayname
Adds a pseudo item similar to "add contact" when you type an email The "standard" way of pasting the invite link under the gear button on the second tab of the "scan QR" dialog is not very straigtforward. The first reflex is to paste it in the search field, so let's handle this.
WofWca
force-pushed
the
handle-invite-link-from-search-input
branch
from
e87a8d4 to
d996e0b
Compare
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pseudo item similar to "add contact" when you type an email
The "standard" way of pasting the invite link under the gear button
on the second tab of the "scan QR" dialog is not very straigtforward.
The first reflex is to paste it in the search field,
so let's handle this.