Add Clone Group functionality #4056
Conversation
maxphilippov
requested review from
WofWca,
Simon-Laux,
nicodh and
farooqkz
and removed request for
WofWca
| if (groupImage && groupImage !== '') { | ||
| await BackendRemote.rpc.setChatProfileImage(accountId, chatId, groupImage) | ||
| } | ||
| groupMembers.push(...chat.contactIds) |
There was a problem hiding this comment.
Is it OK to mutate the parameter? Would it not add the same members twice to the same array if you cloned the group twice?
I'd just clone the array.
| return BackendRemote.rpc.addContactToChat(accountId, chatId, contactId) | ||
| }) | ||
| ) | ||
| finalGroupName = `Copy: ${chat.name}` |
There was a problem hiding this comment.
Not internationalized, but perhaps it's fine.
| const createGroup = useCallback(async () => { | ||
| const isVerified = await areAllContactsVerified(accountId, groupMembers) | ||
| const createGroup = useCallback( | ||
| async (groupTemplateId?: number | null) => { |
There was a problem hiding this comment.
| async (groupTemplateId?: number | null) => { | |
| async (groupTemplateId?: number) => { |
| [accountId, groupImage, groupMembers, groupName] | ||
| ) | ||
|
|
||
| return async (groupTemplateId?: number | null) => { |
There was a problem hiding this comment.
| return async (groupTemplateId?: number | null) => { | |
| return async (groupTemplateId?: number) => { |
|
thanks for pushing this forward. some remarks:
so, in general, we should do the same as on android: open the "Create Group" screen with some memberlist/name/avatar preset from the old group, but crate the group only when the user explicitly hits "Create". see android/ios to get a feeling about the flow |
maxphilippov
force-pushed
the
maxph/clone_group
branch
from
8d7b1b3 to
924571e
Compare
maxphilippov
force-pushed
the
maxph/clone_group
branch
from
924571e to
6026b16
Compare
- useCreateGroup returned function (CreateGroup) now accepts optional groupTemplateId same way Android/iOS version do, this is a group chat id to base new chat on - resolves #3933
maxphilippov
force-pushed
the
maxph/clone_group
branch
from
6026b16 to
52eb279
Compare
useCreateGroup returned function (CreateGroup) now accepts optional groupTemplateId same way Android/iOS version do, this is a group chat id to base new chat on
resolves add "clone group" #3933