refactor: add more comments about scrolling, simplify the code #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
WofWca
force-pushed
the
wofwca/simpler-scrolling
branch
from
046bd57 to
68b8771
Compare
3 tasks
nicodh
approved these changes
Sep 30, 2024
remove non-functional `ev.preventDefault()` It was introduced in 3473014, where it apparently used to disable scroll "sticking to top". Nowadays this "sticking" doesn't tend to manifest itself because we now have a 200px margin, unlike when `preventDefault` was introduced.
`appendMessagePageTop` -> `appendMessagesTop` `appendMessagePageBottom` -> `appendMessagesBottom` We used to use "pages" for messages but now it's not the case.
WofWca
force-pushed
the
wofwca/simpler-scrolling
branch
from
68b8771 to
8fbf83d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was very hard to work on #3763 and #3753 because of how much scrolling-related code we have, so I simplified it and added some comments before I forget.