fix: chatlist image thumbnails not showing on Win #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-windows-chatlist-image-thumbnail
branch
from
64a7806 to
3d42f16
Compare
The `url()` wants a string, so let's give it a string. Otherwise it treats backwards slashes, which used in Windows paths, as escape characters, which results in an invalid URL. The bug was introduced in 72bb581, then there was a fix for something in 87ba793. Though it feels like there should be a proper way to convert file paths to URL...
WofWca
force-pushed
the
wofwca/fix-windows-chatlist-image-thumbnail
branch
from
3d42f16 to
0f45c16
Compare
Simon-Laux
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
url()wants a string, so let's give it a string. Otherwise it treats backwards slashes, which used in Windows paths, as escape characters, which results in an invalid URL.The bug was introduced in 72bb581,
then there was a fix for something in 87ba793.
Though it feels like there should be a proper way to convert file paths to URL...
I checked some other places where
url(is used and didn't find a problem. Maybe it's best to unify such usage, and more thoroughly explain in JSON-RPC that those are file paths and not URLs.