fix: crash on "About" click if account unselected #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-crash-on-about-click
branch
from
a597c22 to
7d83588
Compare
nicodh
approved these changes
Sep 30, 2024
E.g. after deleting an account. Though the crash did not happen if you're in the process of creating an account, or on the initial "onboarding" screen, because that would make an "uninitialized" account and we'd be fine, so this fix is not super impactful. This is similar to cee1010.
WofWca
force-pushed
the
wofwca/fix-crash-on-about-click
branch
from
7d83588 to
ae20ef3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. after deleting an account.
Though the crash did not happen if you're in the process of creating an account, or on the initial "onboarding" screen, because that would make an "uninitialized" account and we'd be fine, so this fix is not super impactful.
This is similar to cee1010.
Yes, I also hate the approach I've taken.