fix: window overflowing small screens #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-overflow-on-smaller-screens
branch
from
723a7c6 to
6e6dc3a
Compare
|
zoom and system dpi are 2 different scaling factors. maybe we should rather just remove the min size? or we somehow find out dpi and then somehow incorporate it into the calculation. Also this affects the other windows too, if I'm not mistaken? |
Yes.
I was thinking about that as well, but wasn't sure if it's OK. WhatsApp, Signal, Telegram enforce min size. I'm worried that there might be a strong reason for that. |
...with high zoom level. Closes #4063
WofWca
force-pushed
the
wofwca/fix-overflow-on-smaller-screens
branch
from
6e6dc3a to
7023a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...with high zoom level.
Closes #4063
I did not test this because for me
setMinimumSizeis not working. Though I played around with window sizes to determine the new numbers.