Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: improve jumpToMessage scrolling #4204

Merged

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Oct 10, 2024

Don't scroll the message list if the message is already visible.

@WofWca WofWca force-pushed the wofwca/jump-to-message-dont-scroll-if-already-in-view branch from 071d3a2 to 2b72fea Compare October 10, 2024 17:22
@WofWca WofWca marked this pull request as ready for review October 10, 2024 17:22
@WofWca WofWca force-pushed the wofwca/jump-to-message-dont-scroll-if-already-in-view branch from 2b72fea to 7a05638 Compare October 10, 2024 17:23
Don't scroll the message list if the message is already visible.
@WofWca WofWca force-pushed the wofwca/jump-to-message-dont-scroll-if-already-in-view branch from 7a05638 to 8cd9014 Compare October 10, 2024 17:26
Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by testing

Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also reviewed by testing.

@Simon-Laux Simon-Laux merged commit 5f0efe1 into main Oct 22, 2024
7 checks passed
@Simon-Laux Simon-Laux deleted the wofwca/jump-to-message-dont-scroll-if-already-in-view branch October 22, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants