improvement: improve a11y #4210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/a11y-2
branch
2 times, most recently
from
a00b4fd to
dcdc7db
Compare
This was referenced Oct 12, 2024
6 tasks
WofWca
force-pushed
the
wofwca/a11y-2
branch
4 times, most recently
from
82467f1 to
b0d6655
Compare
WofWca
force-pushed
the
wofwca/a11y-2
branch
10 times, most recently
from
78885b4 to
c926e84
Compare
nicodh
approved these changes
Oct 29, 2024
|
Rebased |
WofWca
added a commit
that referenced
this pull request
Oct 30, 2024
Closes #2141 Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops. TODO: - [ ] Address the TODOs in the code - [ ] Manage what's gonna be the initially active message, because initially they're all active, so tabbing to the messages list from the top selects the first rendered one as the active one. #4292 could help with this. This is also not great for performance: changing `tabindex` on a bunch of messages makes them all re-render. And otherwise, we probably want to update which one is the active one as new messages arrive. - [ ] The interactive items with `onClick` must be actual semantic `<button>`s. See #4210 for reference.
11 tasks
WofWca
added a commit
that referenced
this pull request
Oct 30, 2024
Closes #2141 Basically what this commit comes down to: 1. Apply `useRovingTabindex` for message items 2. Set `tabindex="-1"` on all the interactive items inside every message that is currently not the active one, so that they do no have tab stops. TODO: - [ ] Address the TODOs in the code - [ ] Manage what's gonna be the initially active message, because initially they're all active, so tabbing to the messages list from the top selects the first rendered one as the active one. #4292 could help with this. This is also not great for performance: changing `tabindex` on a bunch of messages makes them all re-render. And otherwise, we probably want to update which one is the active one as new messages arrive. - [ ] The interactive items with `onClick` must be actual semantic `<button>`s. See #4210 for reference.
Partially addresses #4127 FYI the `@mixin button-reset` is actually only used in one place.
At least some of them
In `FullscreenMedia` and `FullscreenAvatar`
Reactions dialog items, that is.
I have manually checked all the `<input`s and ensured that we do not apply `outline` to text inputs (althought whether we want that is debatable).
This is quite a significant change. I tested a lot of placed where the affected code is used, but still might have missed some regression. And perhaps the behavior is still not ideal in some places, but it's better to assess it in its final form after we add [the roving tabindex functionality (arrow key accessibility)](#4224). Either way I think this is an improvement.
Make it not close on keyboard "clicks".
As the new comment mentions, we currently also apply this mixin to elements that are not buttons, so `cursor: pointer` is not applicable there. We apply `cursor: pointer;` to `<button>` elements in another file, there is no need to add it here.
Including vcards.
It has no effect at all
IMO it's still a bit hacky, but at least now it's keyboard-accessible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the commits are independent, thus they can be reviewed and merged / cherry-picked separately. Let me know which particular commits you reviewed, or up to which point, and I'll make a separate MR to merge only those.
I have tried to make sure to not introduce UI / style regressions.
Things that need more testing: