Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: arrow-key navigation for accounts list #4291

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Oct 29, 2024

No description provided.

@WofWca WofWca force-pushed the wofwca/a11y-arrow-keys-everywhere branch 2 times, most recently from da8d413 to 621fdd0 Compare October 30, 2024 15:04
@WofWca WofWca force-pushed the wofwca/a11y-arrow-keys-everywhere branch from 621fdd0 to 08e6726 Compare November 2, 2024 09:44
This is needed so that it can utilize `RovingTabindexProvider`
context.
@WofWca WofWca force-pushed the wofwca/a11y-arrow-keys-everywhere branch 2 times, most recently from c5ecbce to 7eb9725 Compare November 22, 2024 11:22
@WofWca WofWca changed the title improvement: add more arrow-key navigation improvement: arrow-key navigation for accounts list Nov 22, 2024
@WofWca WofWca force-pushed the wofwca/a11y-arrow-keys-everywhere branch from 7eb9725 to aacb042 Compare November 22, 2024 11:24
@WofWca WofWca marked this pull request as ready for review November 22, 2024 11:25
@WofWca WofWca requested a review from nicodh November 22, 2024 11:25
Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.
Code lgtm

@WofWca WofWca merged commit a5fbfd0 into main Nov 22, 2024
10 checks passed
@WofWca WofWca deleted the wofwca/a11y-arrow-keys-everywhere branch November 22, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants