fix: "disappearing messages" dialog wrong value #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-radio-group-value
branch
from
bc9f5a0 to
5e61542
Compare
WofWca
force-pushed
the
wofwca/fix-radio-group-value
branch
from
5e61542 to
743e453
Compare
|
Hold up, this prints warnings now |
The bug was introduced in 0e0d0b8, where we switched from the Blueprint's `RadioGroup` to our custom `RadioGroup`, which had the bug where it would not reflect the actual value if it was changed programmatically. This commit fixes that bug. The bug in `Radio` existed ever since its introduction. The reason for using `defaultChecked` instead of `checked` probably was the fact that React would complain that "input doesn't have `onChange` listener set, use `defaultChecked` instead". I have ligtly checked that "disappearing messages" is the only affected place.
WofWca
force-pushed
the
wofwca/fix-radio-group-value
branch
from
743e453 to
a120989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was introduced in 0e0d0b8,
where we switched from the Blueprint's
RadioGroupto ourcustom
RadioGroup, which had the bug where it would notreflect the actual value if it was changed programmatically.
This commit fixes that bug.
The bug in
Radioexisted ever since its introduction.The reason for using
defaultCheckedinstead ofcheckedprobably was the fact that React would complain that
"input doesn't have
onChangelistener set,use
defaultCheckedinstead".I have ligtly checked that "disappearing messages"
is the only affected place.