Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arrow-key navigation behavior in search #4361

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Nov 27, 2024

The "contacts" section items were not included
in the roving tabindex winget: they all had individual tab stops,
which is very confusing.

Before:

2024-11-27-ywlrjCfNGl.mp4

After (it is not clear, but I have to press Tab to get to the "Contacts" section):

2024-11-27-HBTw1oFKGy.mp4

@WofWca WofWca force-pushed the wofwca/fix-roving-tabindex-in-search branch from b84d22f to ebed17e Compare November 27, 2024 14:48
@WofWca WofWca added accessibility bug Something isn't working labels Nov 27, 2024
The "contacts" section items were not included
in the roving tabindex winget: they all had individual tab stops,
which is very confusing.
@WofWca WofWca force-pushed the wofwca/fix-roving-tabindex-in-search branch from ebed17e to e1e6e08 Compare November 27, 2024 14:49
@WofWca WofWca marked this pull request as ready for review November 27, 2024 14:51
Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by testing & reading

@WofWca WofWca merged commit 4899103 into main Nov 28, 2024
10 checks passed
@WofWca WofWca deleted the wofwca/fix-roving-tabindex-in-search branch November 28, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants