fix: fullscreen images getting cropped a bit #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/4320-fix-fullscreen-image-cropping
branch
from
7784fab to
1e5c8a7
Compare
maxphilippov
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
I couldn't reproduce the actually "cutting off" part on recent main, but this fixes empty space at the bottom of fullscreen image (something around 5px) I have on main. And it also doesn't make have weird padding which I found when I first investigated this issue. Thanks!
Yes, that's part of it (for me at least). There is padding at the bottom, and the top is cropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4320