style: fix reactions to stickers overlapping #4433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of `max-width: 80%`, which refers to 80% of the wrapper square, and not the chat section (the later was apparently the intention). This has been introduced in #4315, which has later been sort of reverted, but not completely, in #4407. So, let's remove the residuals, especially that stickers also have fixed `height: 200px`, so `max-height` doesn't make sense.
WofWca
changed the title
Apparently this `margin-bottom: -7px` is a residue from copy pasting it from `.metadata` for regular text messages. We have `marin: 0` set for image-only messages, so we should set `margin: 0` for sticker messages as well. Similar MR: #4237.
WofWca
force-pushed
the
wofwca/fix-sticker-reactions-overlapping
branch
from
1fcc1fd to
71633d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #4432.
Before / after
Apparently this
margin-bottom: -7pxis a residuefrom copy pasting it from
.metadatafor regular text messages.We have
marin: 0set for image-only messages,so we should set
margin: 0for sticker messages as well.