Move rust-toolchain file from the core repository #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way updating the core does not automatically update toolchain version and any toolchain can be used as long as it can build the core.
|
Once this is merged, we can remove rust-toolchain from the core repository and stop forcing all developers to use the same toolchain for core building. Core developers should be able to use nightly or beta if they want, Android can be upgraded to the latest stable release and iOS can stay with 1.64.0 if there are currently problems with building on a new version (see #1775, #1771). |
`rust-toolchain` is accessed from `DcCore` subdirectory, therefore, just `../rust-toolchain` does the job.
r10s
force-pushed
the
link2xt/pin-rust-toolchain
branch
from
5b9eb0a
to
fd51090
Compare
r10s
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way updating the core does not automatically update toolchain version and any toolchain can be used as long as it can build the core.
Similar change for Android: deltachat/deltachat-android#2440