Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable "mark all read" button when it does nothing #1893

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

Simon-Laux
Copy link
Member

This also helps with understanding what it does,
because you can now only click it if there are messages that can be marked as read.

Basically it disables the button if there are no unread archived chats.

Bildschirmfoto 2023-06-05 um 21 12 10 Bildschirmfoto 2023-06-05 um 21 11 52

This also helps with understanding what it does,
because you can now only click it if there are messages that can be marked as read.
@Simon-Laux Simon-Laux added the enhancement actually in development, user visible enhancement label Jun 5, 2023
@Simon-Laux Simon-Laux requested review from cyBerta and r10s June 5, 2023 19:17
r10s
r10s previously approved these changes Jun 5, 2023
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a great improvement!

deltachat-ios/Controller/ChatListController.swift Outdated Show resolved Hide resolved
deltachat-ios/Controller/ChatListController.swift Outdated Show resolved Hide resolved
@r10s r10s self-requested a review June 5, 2023 21:08
@r10s r10s dismissed their stale review June 5, 2023 21:08

did not want to approve, see comments above :)

@Simon-Laux Simon-Laux merged commit 6f417bb into master Jun 6, 2023
@Simon-Laux Simon-Laux deleted the disable_mark_as_read_button_if_it_has_no_effect branch June 6, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement actually in development, user visible enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants