Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --no-sanitize-env to cargo-lipo (todo replace) #2142

Closed
wants to merge 3 commits into from

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Apr 4, 2024

Otherwise it clears IPHONEOS_DEPLOYMENT_TARGET variable
and core gets built for wrong iOS version instead of 12.0.

Fixes #2104

Otherwise it clears IPHONEOS_DEPLOYMENT_TARGET variable
and core gets built for wrong iOS version instead of 12.0.
@link2xt link2xt requested a review from r10s April 4, 2024 13:34
@link2xt
Copy link
Contributor Author

link2xt commented Apr 4, 2024

Attempt to build with xcodebuild -workspace deltachat-ios.xcworkspace -scheme deltachat-ios -destination "platform=iOS Simulator,name=iPhone SE (3rd generation)" fails for me with this error currently:

error: lto can only be run for executables, cdylibs and static library outputs

Seems to be this issue: rust-lang/cargo#6375
I have moved LTO to a cargo environment variable.

@link2xt
Copy link
Contributor Author

link2xt commented Apr 4, 2024

@r10s You can try all three commits, maybe the first one works as well. Not sure about removing bitcode also.

@link2xt link2xt changed the title Pass --no-sanitize-env to cargo-lipo Pass --no-sanitize-env to cargo-lipo (todo replace) Apr 4, 2024
@link2xt
Copy link
Contributor Author

link2xt commented Apr 4, 2024

Replaced with #2143

@link2xt link2xt closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hundreds of warnings when linking core main branch
1 participant