-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable LTO via cargo
profile setting
#2145
Conversation
2d303fb
to
2a3c6c2
Compare
This breaks the build even for core v1.136.6 somehow:
EDIT: Enabled LTO in dev profile too, otherwise mullvad/system-configuration-rs#41 is triggered. |
2a3c6c2
to
8c20501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added For me main core builds now also with Rust 1.73.0 (until the breaking change that requires 1.77) |
Enabling LTO via RUSTFLAGS results in error: lto can only be run for executables, cdylibs and static library outputs
8c20501
to
476016b
Compare
ah, i will try over
what do you mean by that? did you try some special commit? the original error of #2144 was fixed for me as well |
I tried commit 5bda4f0c2640f94cebd44b526cc1be40f94728f2, this is currently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yip, with core at 5bda4f0c2640f94cebd44b526cc1be40f94728f2 , build succeeds without warnings or errors! (testing on rust 1.77 already, on both, real-device and simulator, all fine)
@link2xt shall we do a core release at 5bda4f0c2640f94cebd44b526cc1be40f94728f2 ? might be handy for proceeding |
Why not from the latest commit then, now that we have Rust 1.77? |
that one did not build for me ... but let me double check, with all these changes PR and submodule checkouts one easily get confused. i'll file a new issue if things fail |
i double checked, seems i messed sth up myself on last try, now current core main branch builds - in ci, in simulator and on real device, #2146 |
RUSTFLAGS results in
error: lto can only be run for executables, cdylibs and static library outputs
Upstream issue: rust-lang/cargo#6375
Fixes #2144