fix: improve UX with link behavior, spelling, education labels and word count #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arian81
commented
Oct 21, 2024
•
arian81
commented
- open links in new tabs
- correct spelling of lookout
- add optional to education labels
- make word count ux better
|
✅ Deploy Preview for dh-portal-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
arian81
changed the title
Krish120003
approved these changes
Oct 21, 2024
arian81
added a commit
that referenced
this pull request
Oct 24, 2024
* feat: updated schedule for DH10 (#179) * chore: setup using google api * chore: use google api * feat: make calendar work * feat: add schedule button --------- Co-authored-by: Arian Ahmadinejad <35879206+arian81@users.noreply.github.com> Co-authored-by: Arian Ahmadinejad <ahmadinejadarian@gmail.com> * chore: hide logout on schedule * chore: add caching * chore: add attendee package button * feat: add event locations to schedule (#182) * decoupled a lot of functionality in schedule.tsx * fixed getDefaultCurrentDate refactor * cleaned up schedule.tsx from merge * added location to the description * removed console.logs * added location to subheading of events * doing some cleanup * removed removeResourceLabel since description is now unviewable * removed removeResourceLabel since description is now unviewable * making pop viewable again because it needs to be * support 5 colour option * fixing tooltip * fix: disable pop up * added circles in agenda view --------- Co-authored-by: Rachelle DeMan <demanr@mcmaster.ca> Co-authored-by: Krish <krish120003@gmail.com> Co-authored-by: Arian Ahmadinejad <ahmadinejadarian@gmail.com> * fix: schedule login hot fix * fix: hotfix update z indexing on mobile, add sign in button * fix: uncomment out appointmentTooltipRender (#184) * decoupled a lot of functionality in schedule.tsx * fixed getDefaultCurrentDate refactor * cleaned up schedule.tsx from merge * added location to the description * removed console.logs * added location to subheading of events * doing some cleanup * removed removeResourceLabel since description is now unviewable * removed removeResourceLabel since description is now unviewable * making pop viewable again because it needs to be * support 5 colour option * fixing tooltip * fix: disable pop up * added circles in agenda view * uncommented out tooltip render --------- Co-authored-by: Rachelle DeMan <demanr@mcmaster.ca> Co-authored-by: Krish <krish120003@gmail.com> Co-authored-by: Arian Ahmadinejad <ahmadinejadarian@gmail.com> * feat: Create LICENSE * chore: cleanup old components (#187) Remove Google Analytics, Logrocket and unused files. Also mark routers for deprecation. * feat: add posthog * refactor: make drawer component (#189) * created Drawer component * decoupled Drawer out of welcome page * decoupled Drawer out of dashboard, grade, me, and scanner pages * change ApplicationTable button text from View Application to View * remove unused files * cleaning up file dependencies * removed navigation file * feat: DH11 Applications (#196) * feat: DH11 application and review tables * fix: update logsnag project * feat: add user to dh11 applications * feat: use DH11 Applications * fix: update routes to refer to dh11 * feat: prisma db migration * fix: remove broken migrationi * feat: change from DH10 to DH11 everywhere * fix: form is submittable * fix: improve errors * fix: don't refetch autofill * fix: more better errors for form * fix: typos * fix: add better errors * fix: more typos * fix: custom socials form handling (#198) * refactor: rearrage files * feat: add react icons * fix: imports * feat: fixes to form, review endpoint and ui update * fix: imports * fix: update routing and style consistency for dh11 (#199) * fix: disable outdated pages * fix: update routing to use DH11 status, capitalize name * fix: update modal styling * fix: readable dark button text color * feat: use same button as dashboard * feat: match dark and light primary colors * fix: restore original background * fix: match text styling with dashboard * fix: routing TS errors * feat: create prisma migration (#200) * fix: MLH form fields and resume are optional, change form persist key for DH11 (#201) * feat: update socials and info about DH11 (#202) * fix: update DH11 socials * fix: update hackathon length * fix: improve UX with link behavior, spelling, education labels and word count (#203) * fix: open links in new tab * fix: spelling of lookout * fix: add optional to education labels * fix: make word count ux better * fix: show word count on grading page instead of words left --------- Co-authored-by: Krish <krish120003@gmail.com> * feat: add resume upload (#204) * feat: DH11 application and review tables * fix: update logsnag project * feat: add user to dh11 applications * feat: use DH11 Applications * fix: update routes to refer to dh11 * feat: prisma db migration * feat: backend for uppy signed url upload * fix: remove unnecessary validation, store at root * fix: cleanup packages * feat: basic upload component * feat: add endpoint for getting resume files * feat: handle uppy upload responses * fix: handle empty string dates * feat: connect uppy to react form * fix: prettier formatting * fix: add missing types * fix: make form mobile friendly again * fix: remove migration * fix: add missing libraries --------- Co-authored-by: Krish120003 <krish120003@gmail.com> * fix: posthog rewrite using netlify * feat: add posthog submission tracking * feat: use netlify redirects for posthog, add identification and apply event capture (#205) * feat: add posthog identify * fix: upgrade posthog * fix: pnpm lock * fix: use posthog suggested event naming * fix: add missing space * feat: add logsnag track for dh11 application * fix: correct host * fix: add posthog on server * fix: use component to identify in posthog * fix: use consistent id --------- Co-authored-by: Arian Ahmadinejad <ahmadinejadarian@gmail.com> --------- Co-authored-by: Krish <krish120003@gmail.com> Co-authored-by: Felix Fong <fongf2@mcmaster.ca> Co-authored-by: Rachelle DeMan <demanr@mcmaster.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.