-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve judging form design, show table projects list #236
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for dh-portal-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/server/router/judging.ts:178
- The new behavior introduced in the getNextProject function should be covered by tests to ensure that the correct project is returned when a projectId is provided.
if (input.projectId) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* slight improvements * refactor redundant code * add projects list * improve form design * fix small bug where no project is auto selected when all projects have already been judged * fix: show no project left message when judging is done --------- Co-authored-by: Arian Ahmadinejad <ahmadinejadarian@gmail.com>
Improved the judging form design, and added a list of projects which the judge can use to navigate to different projects at the table. They can also update their previously submitted scores.
Demo:
Screen.Recording.2025-01-09.at.9.50.50.PM.mov
Desktop dark:
Desktop light:
Mobile dark:
Mobile light: