Sync with delta #190
Merged
Sync with delta #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS related + AsRef<Path> bugfixes
* Fix examples not being detected I am unsure what the `target.cfg` does but it made so that running `cargo run --example <example_name>` gave `no example target <example_name>` error. Removing it allows cargo to detect and run examples. * Add missing specs.rs and roguelike.rs files * Disable broken examples to make unit tests pass * Port floppy example to rust * Fix specs.rs Specs adds three new dependencies to the project. * Fix asteroids.rs * Fix drop.rs - Use newer api to load sound - When a window is closed the OpenGL context is destroyed, it is not possible to unload a shader after the OpenGL context is destroyed. Hence test_shader_dropping function doesn't work and is removed. * Fix arkanoid.rs * Use d.measure_text insted of rl.measure_text * Fix roguelike.rs * Fix yaw_pitch_roll.rs For some reason plane.obj file was corrupt. I replaced it with the one used in the main raylib repo. * make roguelike.rs require "with_serde" feature * Install sdl in github ci workflow * Make it pass lint test
* build, callbacks: fix/clarify wasm building * build: wasm building requires -O3 to be set in EMCC_CFLAGS, apperently. see emscripten-core/emscripten#19346 * bindings: moved functions for handling log callbacks over to c code * bindings: use our own raylib.h in the c code * audio: rename the 'ready' functions to match their function names * test: updated test to match AsRef PR * audio: brought back PhantomData for RaylibAudio so that the struct is and !Send and !Sync * audio: AsRef for more functions * raylib/cargo, raylib-sys/cargo: realized i had left in some unused imports * callbacks: make custom_trace_log_callback public as a stab in the dark to see if that fixes the windows issue * callbacks,tests: realized that since rust marks our external function as having 'char *' as the first argument on windows-gnu * callbacks: realized the c code wasn't wrapped in extern 'c' when compiling in c++ * callbacks: have windows compile a cpp file instead of a c file for utils_log * fixed the windows link error but now it complains about the char fix i did * log: vsprintf -> vsnprintf * log: use the result of vsnprintf instead of strlen * build: removed some flags i forgot i added. * log: actually, just use from_ptr, because what raylib gives us is always going to end in \0 * tests: disable callbacks test under windows after confirming that the issue literally only happens when we use cargo test * tests: disable callbacks test under windows after confirming that the issue literally only happens when we use cargo test * ci: remove windows test after confirming it only fails under CI. ran cargo clippy --fix
…et and core now works fully on web rgui/physac/rlgl untested on web.
… even on crates.io)
The 5.0.0 update.
…d in the samples (#49)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.