Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] F-Droid can't build #160

Open
licaon-kter opened this issue Jun 7, 2024 · 8 comments
Open

[BUG] F-Droid can't build #160

licaon-kter opened this issue Jun 7, 2024 · 8 comments

Comments

@licaon-kter
Copy link

licaon-kter commented Jun 7, 2024

xposed lib is not available in a trusted maven repo

> Task :app:processFossReleaseResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processFossReleaseResources'.
> Could not resolve all files for configuration ':app:fossReleaseCompileClasspath'.
   > Could not find de.robv.android.xposed:api:82.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/de/robv/android/xposed/api/82/api-82.pom
       - https://repo.maven.apache.org/maven2/de/robv/android/xposed/api/82/api-82.pom
       - https://jitpack.io/de/robv/android/xposed/api/82/api-82.pom
     Required by:
         project :app

ref: e1d1f1e

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/3682805926959d87c6d530d3dd4eeb32f67b6aa8

@deltazefiro
Copy link
Owner

deltazefiro commented Jun 7, 2024

Hi @licaon-kter
I imported the Xposed library from the official Xposed API repository at https://api.xposed.info/. I believe it's a common requirement for every xposed module. Any suggestions for removing it?

@licaon-kter
Copy link
Author

licaon-kter commented Jun 7, 2024

Maybe we can build it from source? Since this is a repro app... I guess you might need to build it too :( :)

Any suggestions for removing it?

move the xposed stuff out of the foss flavor 🤷

@deltazefiro
Copy link
Owner

deltazefiro commented Jun 7, 2024

@licaon-kter
Well, I found that the Xposed library can also be obtained from jcenter, although it is deprecated.
I will create a new release without https://api.xposed.info/ :D

EDIT: New release published v0.9.1

@licaon-kter
Copy link
Author

licaon-kter commented Jun 7, 2024

That fixes it https://gitlab.com/fdroid/fdroiddata/-/commit/8cfa2753b36958f04ddf6fe6fc75ebf7677dc04d

jcenter, although it is deprecated

good luck to future you when the time comes and that is unreachable 🤷

@deltazefiro
Copy link
Owner

good luck to future you when the time comes and that is unreachable 🤷

☹️ There's another solution: we can include the .jar library in the source tree.
However, as per F-Droid Inclusion Policy:

Binary dependencies such as JAR files have to be built from source or installed from Debian repos.

I'm not sure if I can do this. I found that Scoop did so and got included in F-Droid, so I believe it's OK, right?

@licaon-kter
Copy link
Author

Not true, those are not used: https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/taco.scoop.yml#L87

But https://github.com/TacoTheDank/Scoop/blob/v2.4.2/build.gradle#L9

@ThreeDeeJay
Copy link

Yeah, looks like the Xposed API was removed from official repositories.
Luckily I found a mirror (not sure how trustworthy it is, though, perhaps someone could compare the hashes?):
https://github.com/ThreeDeeJay/DarQ/blob/3231ce1f0962f9d57596499319560f6e942c5232/build.gradle#L22

This archive might work if that repo ever goes under (unless Internet Archive beats it to the punch given recent events)

maven { url "https://web.archive.org/web/20240907130748/https://archiva.interlocsolutions.com/archiva/repository/internal" }

Like, seriously, how come nobody ever though of archiving this?

https://dl.google.com/dl/android/maven2/de/robv/android/xposed/api/82/api-82.pom

@licaon-kter
Copy link
Author

Jcenter was finally turned off, yes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants