Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] bad shortcut #22

Closed
Wjxfi opened this issue Jan 19, 2023 · 20 comments
Closed

[BUG] bad shortcut #22

Wjxfi opened this issue Jan 19, 2023 · 20 comments
Labels
bug Something isn't working

Comments

@Wjxfi
Copy link

Wjxfi commented Jan 19, 2023

Describe the bug / 问题描述
A clear and concise description of what the bug is.
请清晰地描述您遇到的异常。
the shortcut behaves very strangely. It doesn't work for a while, with multiple clicks, and then shows the wrong color. When the shortcut is blue, something must be on. Here on the contrary, it is off. This is not right.

Screenshots / 截图
If applicable, add screenshots to help explain your problem.
(可选)问题复现时候的截图或录屏。
https://user-images.githubusercontent.com/113500363/213538443-5457a71c-3f38-4fbd-84e9-8e90f3c679d7.mp4

To Reproduce / 复现步骤
Steps to reproduce the behavior / 复现异常的步骤:

  1. click on shortcut

Expected behavior / 预期行为
A clear and concise description of what you expected to happen.
描述您认为正常情况下应该发生什么。
works correctly from the first click. When file hiding is on, the shortcut turns blue.

Basic Information: / 请填写以下信息:

  • OS (ROM) / 系统:
    miui 12.0.6
  • Android Version / 安卓版本: [e.g. 12]
    androis 12
  • Amarok Version / Amarok版本: [e.g. v0.8.1b1-foss]
    0.8.2a3
@Wjxfi Wjxfi added the bug Something isn't working label Jan 19, 2023
@deltazefiro
Copy link
Owner

deltazefiro commented Jan 20, 2023

Uh yes, that's a known bug. Hard to fix.
WIP

@deltazefiro
Copy link
Owner

Done! Give this a try.

@Wjxfi
Copy link
Author

Wjxfi commented Jan 31, 2023

Done! Give this a try.

1 click. The color of shortcut did not change, the application wrote hidden. Press 2. The application wrote unhidden, the color shortcut became blue

bad, the problem hasn't disappeared

But don't worry, it's better than before, I think

@deltazefiro
Copy link
Owner

deltazefiro commented Jan 31, 2023

May related to MIUI's battery saving strategy.
Go to system settings, Manage Apps > Amarok > Battery saver > switch to No restrictions.

@Wjxfi
Copy link
Author

Wjxfi commented Feb 1, 2023

May related to MIUI's battery saving strategy.
Go to system settings, Manage Apps > Amarok > Battery saver > switch to No restrictions.

other applications work fine with shortcut, and I have not clicked "no restrictions" mode for them

shortcut now works very well but the problem is the color. It's blue when it's off

the problem is in the first click on the shortcut. On my first click it does not turn blue, but it said hidden (I think)

the first click caused the problem (I think)

I did what you said, but it didn't help

@deltazefiro
Copy link
Owner

deltazefiro commented Feb 1, 2023

shortcut now works very well but the problem is the color. It's blue when it's off

It works as is. The shortcut should be "Active" (or blue) when Amarok is not in the hidden state - well it's kinda counterintuitive, but I'd rather keep it "Inactive" (grey) at most of the time. And I believe users would keep amarok in hidden state at most of the time.

the problem is in the first click on the shortcut. On my first click it does not turn blue, but it said hidden

WIP.

@Wjxfi
Copy link
Author

Wjxfi commented Feb 1, 2023

It works as is. The shortcut should be "Active" (or blue) when Amarok is not in the hidden state - well it's kinda counterintuitive, but I'd rather keep it "Inactive" (grey) at most of the time. And I believe users would keep amarok in hidden state at most of the time.

Okay. It's just that all the other apps turn blue when they work, but this one does the opposite

I thought it was wrong. But it is right. Sorry

@deltazefiro
Copy link
Owner

Yes the color is a little bit unconventional 😆
Try this ci build. Maybe it tackled the "first click" problem.

@Wjxfi
Copy link
Author

Wjxfi commented Feb 2, 2023

Yes the color is a little bit unconventional 😆
Try this ci build. Maybe it tackled the "first click" problem.

application is not installed (error)

@deltazefiro
Copy link
Owner

application is not installed (error)

Uninstall the old version Amarok and try again.

@Wjxfi
Copy link
Author

Wjxfi commented Feb 2, 2023

application is not installed (error)

Uninstall the old version Amarok and try again.

It wasn't a problem, but I fixed it. the error didn't go away, it turned blue for a second and then went back to normal

@deltazefiro
Copy link
Owner

it turned blue for a second and then went back to normal

🤔 Could you provide a new screen recording?

@Wjxfi
Copy link
Author

Wjxfi commented Feb 3, 2023

it turned blue for a second and then went back to normal

🤔 Could you provide a new screen recording?

I reinstalled the app and now it just stays gray the first time
https://user-images.githubusercontent.com/113500363/216519300-44870130-521d-4afa-9866-51f4287a2623.mp4

@deltazefiro
Copy link
Owner

deltazefiro commented Feb 3, 2023

Weird. I'm using almost the same environment you are using - MIUI & Android 12. I cannot reproduce this issue.

Screenrecorder-2023-02-03-13-40-38-370.0.mp4

@Wjxfi
Copy link
Author

Wjxfi commented Feb 3, 2023

Weird. I'm using almost the same environment you are using - MIUI & Android 12. I cannot reproduce this issue.

it happens after installing the application, once

@deltazefiro
Copy link
Owner

deltazefiro commented Feb 3, 2023

Weird. I'm using almost the same environment you are using - MIUI & Android 12. I cannot reproduce this issue.

it happens after installing the application, once

Cannot reproduce either. And I noticed that your icon label did not turn into "Processing" as expected (see my video above) - does that happen every time, or also only happen in the first time after amarok installed?

@Wjxfi
Copy link
Author

Wjxfi commented Feb 3, 2023

Cannot reproduce either. And I noticed that your icon label did not turn into "Processing" as expected (see my video above) - does that happen every time, or also only happen in the first time after amarok installed?

first time

@deltazefiro
Copy link
Owner

deltazefiro commented Feb 4, 2023

Um... Tried on several more devices. Failed to reproduce. 😞
Well, yeah maybe the issue only happens on few devices - and as it just happens once and has no severe consequences, I think maybe we can just let it go.
I'll place the previous fix in next release and see if anyone else encountered the same issue.

@Wjxfi
Copy link
Author

Wjxfi commented Feb 4, 2023

Um... Tried on several more devices. Failed to reproduce. 😞
Well, yeah maybe the issue only happens on few devices - and as it just happens once and has no severe consequences, I think maybe we can just let it go.
I'll place the previous fix in next release and see if anyone else encountered the same issue.

ok, I'm sorry for wasting your time

@deltazefiro
Copy link
Owner

It's no bother at all! Thanks for reporting the issue and for your support. ❤️
Let's close the issue now. As always, feel free to open a new issue (or ask me to reopen this one) if you find a way to reproduce it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants