This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
Feature/cache op results #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2020 21:34
To cache op list-items results I must first create a file everytime I get any return from the command itself. On this commit, I am creating the logic to save the return from op list-items into a given file for further usage. Now, I just need to add the logic to fetch from this file instead, if the file is new enought.
Now that I can cache the op list-items result, I need to use the cache instead of getting it online, if it exists. It is important to have a TTL on the cache file too. On this commit I'm going to add the logic to use the cache file (if applicable) and also create a rule to use it only when the cache is recent. Now, I've finished the feature and can start using it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.