Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter and linter #33

Closed
wants to merge 8 commits into from
Closed

Add formatter and linter #33

wants to merge 8 commits into from

Conversation

jacobdalamb
Copy link

Added prettier, prettier-plugin-astro, and @biomejs/biome.

@vercel
Copy link

vercel bot commented Sep 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
astro-badge ✅ Ready (Inspect) Visit Preview Oct 22, 2023 7:36am

Copy link
Owner

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I think we probably will want to update this project to Astro 3 before introducing any of these changes.

I’d also suggest we avoid using both Biome AND Prettier unless there’s a very good reason? I believe Biome doesn’t have Astro support yet, so sticking to Prettier would probably be best.

@jacobdalamb
Copy link
Author

Thanks for this!

I think we probably will want to update this project to Astro 3 before introducing any of these changes.

I’d also suggest we avoid using both Biome AND Prettier unless there’s a very good reason? I believe Biome doesn’t have Astro support yet, so sticking to Prettier would probably be best.

Sure thing! It's up to you but both could be used as I looked at this PR using Biome to only format JS and JSON files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants