-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update twitter.mdx #158
Update twitter.mdx #158
Conversation
|
Thanks for the PR @lin-stephanie! In this case though
In this case the Twitter code is a “normal” (i.e. non- Would you want to change this PR to add that attribute where needed? |
3406a90
to
ad4fe6e
Compare
Thank you for the clarification! I now understand that widgets.js is a classic script, not a module. I’ve updated the examples to include the async. Is this change okay? |
This comment was marked as duplicate.
This comment was marked as duplicate.
✅ Deploy Preview for astro-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great — thank you!
I also updated those two pages to include the async
attribute on the actual <script>
tags as well, not only in the code example. That way I could test they worked as expected and they do 🎉
Maybe we should remove
async
to keep it consistent with the example at https://astro-embed.netlify.app/examples/tweet-with-js/, just like the Astro Docs - Script processing suggest.