Fix accessible names for embed youtube link

[anotheri]

ARIA commands must have an accessible name, read more: https://dequeuniversity.com/rules/axe/4.10/aria-command-name

Otherwise i'm getting this issue in lighthouse Accessibility report:

[netlify]

✅ Deploy Preview for astro-embed ready!

Name	Link
🔨 Latest commit	aa4b03f
🔍 Latest deploy log	https://app.netlify.com/sites/astro-embed/deploys/6727e324392edd0008669a41
😎 Deploy Preview	https://deploy-preview-165--astro-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[delucis]

Thanks for the PR!

This looks like it’s actually a bug in the use of attrs.playLabel as a child of the link. As documented in the <YouTube> component docs, this should have a default value of "Play", but it looks like we’re not providing that default, which we should do here:

Suggested change

	<a {href} class="lty-playbtn" role="link" aria-label={title}>
	<span class="lyt-visually-hidden">{attrs.playlabel}</span>
	<a {href} class="lty-playbtn">
	<span class="lyt-visually-hidden">{attrs.playlabel || 'Play'}</span>

In general, actually text content is preferable to aria-label as it is more widely accessible. There is also no need to apply a role="link" to an <a> element as this is already the default role.

[anotheri]

yeah, you're right if i provide playlabel that accessiblity issue gone, so i'll add default value now as you suggested.

[changeset-bot]

🦋 Changeset detected

Latest commit: d1d0c43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@astro-community/astro-embed-youtube	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[delucis]

Perfect — thanks @anotheri! I added a test and changeset and will get this released now.