Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDX integration embeds replace their parent paragraph instead of their link node #66

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

delucis
Copy link
Owner

@delucis delucis commented Oct 21, 2023

Fixes #65

Previously, the remark plugin looked for the equivalent of p > a:only-child to find URLs to potentially replace with an embed and, when finding a URL match, replaced the link node. This resulted in DOM like p > embed.

#65 noticed this was causing issues if embed code included elements not permitted inside <p> (<blockquote> in the case of Twitter’s oEmbed markup). This causes HTML parsing to do some creative stuff and can cause some layout weirdness depending on what a user’s CSS looks like.

This PR updates the remark plugin to replace the full paragraph node with the embed instead of just the link, so this should no longer be an issue.

Existing embeds should render as expected without the wrapper <p> — although spacing between embeds may be impacted (<p> has default margins, but the embed nodes do not).

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2023

🦋 Changeset detected

Latest commit: 9ab9c82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astro-community/astro-embed-integration Minor
astro-embed Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@delucis delucis merged commit 9fba8ef into main Oct 21, 2023
2 checks passed
@delucis delucis deleted the fix/integration branch October 21, 2023 22:33
@github-actions github-actions bot mentioned this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank <p> added between "Tweet" embeds
1 participant