MDX integration embeds replace their parent paragraph instead of their link node #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
Previously, the remark plugin looked for the equivalent of
p > a:only-child
to find URLs to potentially replace with an embed and, when finding a URL match, replaced the link node. This resulted in DOM likep > embed
.#65 noticed this was causing issues if embed code included elements not permitted inside
<p>
(<blockquote>
in the case of Twitter’s oEmbed markup). This causes HTML parsing to do some creative stuff and can cause some layout weirdness depending on what a user’s CSS looks like.This PR updates the remark plugin to replace the full paragraph node with the embed instead of just the link, so this should no longer be an issue.
Existing embeds should render as expected without the wrapper
<p>
— although spacing between embeds may be impacted (<p>
has default margins, but the embed nodes do not).