Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this aims to solve #32
NOT READY TO MERGE
Basically it provides a interface to Spotify iframe snippet, so it's not overly optmized as lite-vimeo and lite-youtube where the iframe only loads on interaction. Should this be done to the Spotify iframe (I don't know how, btw, but could try)?
For reference there's a Svelte and Eleventy library around that utilize this same approach, simple iframe embed.
Found this too: https://github.com/luwes/spotify-audio-element
I couldn't get tests to work, neither by
npm t
, ornpm run test:ci
, actually the latter runs but all fails. But I want to write tests for it.I've tried to use the Spotify oembedAPI but I'm not sure the tradeoffs are worth it. Benefits were having embed html snippet and a 300x300 thumbnail image that would allow us to create a link card component as an option over embedded player (if desired), OTOH more code would be need to allow the current customization options. I'm willing to rewrite if needs so.
Preview:
![](https://private-user-images.githubusercontent.com/61759797/284417161-cb1fa8fb-b120-46b0-b79e-6e48dd4fac46.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNzM4MTAsIm5iZiI6MTczOTE3MzUxMCwicGF0aCI6Ii82MTc1OTc5Ny8yODQ0MTcxNjEtY2IxZmE4ZmItYjEyMC00NmIwLWI3OWUtNmU0OGRkNGZhYzQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA3NDUxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEyZjYzZDIwYjgzMGRiYWM5NTc4OGYyMmI4NjEzOTRiODNmNWRhYmNlYTAwZDY0NWY3N2I5NjJhZWM5OTljNTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7hIHXWCWn-kG-MFMIGJjhvKIbuOhcSG6W4QNrt7kfi4)
![](https://private-user-images.githubusercontent.com/61759797/284417209-b64c734c-d8eb-4136-8a1a-0d9acd3a8866.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNzM4MTAsIm5iZiI6MTczOTE3MzUxMCwicGF0aCI6Ii82MTc1OTc5Ny8yODQ0MTcyMDktYjY0YzczNGMtZDhlYi00MTM2LThhMWEtMGQ5YWNkM2E4ODY2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDA3NDUxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFlMTJhYjZiYjhlMTU0MDhkNmQwZjcwOTczYzBlMTI2YWQ1ZWRjNGM0MWE5OGE2ZmJhN2MzYWZhY2FkNmEyYmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Oy5vz5EMM4UUDdAVI99xfRGfQacjJAxCe4q_l9jKbwc)
Thank you.