Route matching is not falling back to parametric route

[IpaliboWhyte]

I'm running Restify 7.x in production and I was able to reproduce an issue I discovered down here.

Consider the following:

const http = require('http')
const router = require('find-my-way')()

router.on('GET', '/a/bbbb', (req, res) => {
  res.end('{"message":"hello world"}')
})

router.on('GET', '/a/bbaa', (req, res) => {
  res.end('{"message":"hello world"}')
})

router.on('GET', '/a/babb', (req, res) => {
  res.end('{"message":"hello world"}')
})

router.on('DELETE', '/a/:id', (req, res) => {
  res.end('{"message":"hello world"}')
})

console.log(router.find('DELETE', '/a/bar')); 
// => { handler: [Function], params: { id: 'bar' }, store: null }

console.log(router.find('DELETE', '/a/bbar')); 
// => null

console.log(router.prettyPrint());
// └── /
//     └── a/
//         ├── b
//         │   ├── b
//         │   │   ├── bb (GET)
//         │   │   └── aa (GET)
//         │   └── abb (GET)
//         └── :id (DELETE)

const server = http.createServer((req, res) => {
  router.lookup(req, res)
})

server.listen(3040, err => {
  if (err) throw err
  console.log('Server listening on: http://localhost:3040')
})

If router.on('GET', '/a/bbaa',...) is taking out, DELETE /a/bbar seems to be matched otherwise, I get a 404. Any ideas why this is happening?

Thanks in advance!

[delvedor]

Hello! I'll look at this as soon as I have time.
If you have time to try to debug it, be my guest! :)

[mcollina]

cc @hekike

[IpaliboWhyte]

Had a look and it looks like parametricBrother only gets propagated to the first level STATIC children and not all STATIC descendants in Node.prototype.addChild.

[mcollina]

Would you like to send a PR?

[IpaliboWhyte]

Yes, currently working on it.

[IpaliboWhyte]

Found another scenario, this is actually from the routes defined in example.js file.

const router = require('./')()

router.on('GET', '/test', (req, res, params) => {
  res.end('{"hello":"world"}')
})

router.on('GET', '/:test', (req, res, params) => {
  res.end(JSON.stringify(params))
})

router.on('GET', '/text/hello', (req, res, params) => {
  res.end('{"winter":"is here"}')
})

console.log(router.find('GET', '/testy'));
// => null

I'm not 100% sure this is happening for the same reason, will take a look into this.

[IpaliboWhyte]

Closing this as issue is now fixed