-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect parametric brother route set up. #222
Comments
Would you like to send a Pull Request to address this issue? Remember to add unit tests. |
If you set up routes in a different order this will work router.on('GET', '/:c', () => {})
router.on('GET', '/text/hello', () => {})
router.on('GET', '/text/:e/test', () => {})
assert.deepEqual(router.find('GET', '/text/hellos/test').params, { e: 'hellos' }) |
ivan-tymoshenko
added a commit
to ivan-tymoshenko/find-my-way
that referenced
this issue
Dec 23, 2021
delvedor
pushed a commit
that referenced
this issue
Dec 27, 2021
This was referenced Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes it sets a non-nearest parametric brother route. Static route
/text/hello
will have/:c
as a parametric brother, but should havetext/:e/test
.It's not the same issue with (#221)
The text was updated successfully, but these errors were encountered: