Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print improvements #144

Closed

Conversation

ElianCordoba
Copy link
Contributor

Output differences

before
└── / (GET|POST)
    ├── a (GET|PUT)
    │   └── /
    │       ├── :a (GET)
    │       └── b (GET)
    ├── b (GET)
    └── :test (GET)
        :test (PUT)
        └── /hello (GET)
after
/
├── (GET)
├── (POST)
│ 
├ a
│ ├── (GET)
│ ├── (PUT)
│ │ 
│ └ /
│   ├── :a (GET)
│   └── b (GET)
├── b (GET)
└ :                         <- Note here, this is diferent that before
  ├── :test (GET)
  ├── :test (PUT)
  │ 
  └── /hello (GET)

I had to do some monkey patching because the part of the tree generated by archy would not look good, not proud of that code but it works.

To be honest, I like the original output more but this new approach allows for the handler's name to be displayed.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@airhorns
Copy link
Contributor

airhorns commented Feb 9, 2021

#170 included work that supersedes this, I think this can be closed

@delvedor
Copy link
Owner

delvedor commented Feb 9, 2021

Thank you for contributing @ElianCordoba!

@delvedor delvedor closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants