Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement '.' separator in parametric routes #193

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Implement '.' separator in parametric routes #193

merged 1 commit into from
Jun 15, 2021

Conversation

MSE99
Copy link
Contributor

@MSE99 MSE99 commented Jun 11, 2021 •
edited
Loading

Closes #192

Implements . as a separator between route params (similar to how - works), PR also refactors all - tests to test for . too.

mcollina
mcollina approved these changes Jun 11, 2021
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from delvedor June 11, 2021 14:14
delvedor
delvedor approved these changes Jun 15, 2021
View reviewed changes
Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina not sure why you marked this as bug, it looks line an enhancement to me.

@mcollina mcollina merged commit 904ee1a into delvedor:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route with a . (period) between parameters
3 participants
@MSE99 @mcollina @delvedor