Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize benchmark paths #267

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

ivan-tymoshenko
Copy link
Collaborator

Benchmark refactoring:

  • Updated benchmarks paths. All benchmark test routes have different paths and it takes significant time to iterate a path char by char. So some test cases can look really slow, not for the reason we are trying to test, but just because they have lost static prefix. I made paths the same where it makes sense, so it's easier to compare benchmarks between themselves.
  • Removed find method benchmarks. Almost all find method benchmarks are duplicating lookup benchmarks. They have some sense because lookup adds some overhead by deriving constraints and calling a handler. But since we use an empty handler and almost empty constraint this overhead is really small and constant. From my experience find method benchmarks don't give any new information, after running lookup benchmarks.
  • Added some new benchmarks.
  • Aligned test names.

Снимок экрана 2022-04-29 в 20 09 13

Copy link
Contributor

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. LGTM

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 42086fd into delvedor:main Apr 29, 2022
@ivan-tymoshenko ivan-tymoshenko deleted the normalize-benchmarks branch April 29, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants