Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove max param length on wildcard #293

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

climba03003
Copy link
Contributor

Fixes fastify/fastify#3957

It is very common that people expect wildcard route as a fallback / catch-all route in their application.
Since, it will match all the thing include each path segment.
Restricting the length of wildcard like the other param / regexp seems unnecessary and out of user expectation.

I think this behavior is bring from #237

Copy link
Collaborator

@ivan-tymoshenko ivan-tymoshenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 45379cd into delvedor:main Jun 1, 2022
@climba03003 climba03003 deleted the fix-wildcard branch June 1, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 OPTIONS error only on one request
4 participants