Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating both * and /* routes #297

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Avoid creating both * and /* routes #297

merged 2 commits into from
Jul 28, 2022

Conversation

mcollina
Copy link
Collaborator

@mcollina mcollina commented Jul 27, 2022 •
edited
Loading

Signed-off-by: Matteo Collina hello@matteocollina.com

Fixes fastify/fastify-static#325

@mcollina
Avoid creating both * and /* routes
e5d0278 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina mentioned this pull request Jul 27, 2022
Closed
2 tasks
Uzlopak
Uzlopak approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good night.

kibertoad
kibertoad reviewed Jul 27, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
delvedor
delvedor approved these changes Jul 28, 2022
View reviewed changes
Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
fixup
a45d059 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina merged commit e439d6e into main Jul 28, 2022
@mcollina mcollina deleted the fix-double-wildcard branch July 28, 2022 08:50
@ivan-tymoshenko ivan-tymoshenko mentioned this pull request Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad left review comments

@Uzlopak Uzlopak Uzlopak approved these changes

@delvedor delvedor delvedor approved these changes

@ivan-tymoshenko ivan-tymoshenko Awaiting requested review from ivan-tymoshenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to serve static files with Vite + SSR
4 participants
@mcollina @kibertoad @delvedor @Uzlopak