Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error for wildcard route with suffix #306

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Add error for wildcard route with suffix #306

merged 1 commit into from
Oct 2, 2022

Conversation

ivan-tymoshenko
Copy link
Collaborator

mcollina
mcollina approved these changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit c537cdb into main Oct 2, 2022
@mcollina mcollina deleted the add-error-for-wildcard-route-with-suffix branch October 2, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: currentNode.createStaticChild is not a function for wildcard route
2 participants
@ivan-tymoshenko @mcollina