feat: add multiple parametric nodes support

[ivan-tymoshenko]

Close #317

[mcollina]

does this affects our benchmarks?

[ivan-tymoshenko]

No, all changes are in the compile time.

[ivan-tymoshenko]

This PR is ready to review. It allows you to have two identical routes with different param types: general parameter and regexp parameter.

Example:

• /foo/:param
• /foo/:param(123)

Code in the index.js is pretty tricky. I don't ask you to review it unless you have a lot of time to deal with it. Please take a look at two things:

1. Params sorting function. It describes how we would prioritese parametric nodes. (param node with long suffix -> param node with short suffix -> regexp node -> param node without suffix)

2. Please look at the test file. It more or less describes all params collisions and priorities. It's pretty simple and readable.

If you have any suggestions, you are more than welcome.

cc @mcollina @climba03003 @Eomm

[mcollina]

Can you add some docs for this?

[climba03003]

Can we defer the sorting to certain point later?
For example, once the first call of lookup.

It seems to do a lot of unnecessary sorting when there are many routes.

[ivan-tymoshenko]

Can we defer the sorting to certain point later? For example, once the first call of lookup.

It seems to do a lot of unnecessary sorting when there are many routes.

Technically we can, you are right. But you will have this sorting in a very small amount of cases. You a sorting parametric childs of one parent node. IMHO, in 99% of all use cases, you have one parametric child, and in 1%, you have two children. All other cases are less than the statistical error.

On the other hand, this will complicate the already complicated code and introduce an additional error in measuring the hot path. I would agree with you 100% if it would make any difference, but you will not notice it.

[climba03003]

You a sorting parametric childs of one parent node. IMHO, in 99% of all use cases, you have one parametric child, and in 1%, you have two children. All other cases are less than the statistical error.

At least we can do if(this.parametricChildren.length > 1) to prevent single item array being sorted.

[ivan-tymoshenko]

At least we can do if(this.parametricChildren.length > 1) to prevent single item array being sorted.

I think that the sort function is smart enough to not call a sorting handler for an array with one item. But I can add this, not a problem at all.

[delvedor]

LGTM with some docs!

[climba03003]

At least we can do if(this.parametricChildren.length > 1) to prevent single item array being sorted.

I think that the sort function is smart enough to not call a sorting handler for an array with one item. But I can add this, not a problem at all.

nvm, it is actually smart enough to skip the run.

function sorter(a, b) {
  console.log('did run')
  return a - b
}

;['a'].sort(sorter)
;['a', 'b'].sort(sorter)

[mcollina]

lgtm