feat: use internal trees for prettyPrint #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 6, 2023
climba03003
approved these changes
Mar 9, 2023
Co-authored-by: KaKa <kaka@kakawebsitedemo.com>
Eomm
reviewed
Mar 9, 2023
test/pretty-print.test.js
Outdated
Comment on lines
334
to
335
| └── /:hello (GET) | ||
| /:hello (PUT) |
There was a problem hiding this comment.
Wasn't the GET,PUT collapse good?
There was a problem hiding this comment.
It's doable, but Idk if it's a good idea. For me, it's more clear when each line/branch represents each node. But I'm the wrong person to ask as I don't use pretty print at all.
delvedor
approved these changes
Mar 9, 2023
|
@Eomm related PR in the Fastify: fastify/fastify#4618 |
Eomm
approved these changes
Mar 9, 2023
josephharrington
added a commit
to restify/node-restify
that referenced
this pull request
Apr 20, 2023
This fixes tests related to a recent `find-my-way` release. The relevant change is: delvedor/find-my-way#321
mmarchini
pushed a commit
to restify/node-restify
that referenced
this pull request
Jun 18, 2023
This fixes tests related to a recent `find-my-way` release. The relevant change is: delvedor/find-my-way#321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #315, #316, #271, #82
Problem:
prettyPrintbuilds trees from scratch with a different algorithm. You can't use it for debugging and you always need to keep real trees and printed trees synced. It's literally another small router nested into the big one.Solution: don't emulate the trees. I added a new option to the
prettyPrintfunction:method. If you pass it, fmw will print you an internal tree. If you don't pass it, fmw will create a new router, merge all trees with a constraint hack, and will print the merged tree.The logic of
commonPrefix: falsewill be a little bit different.+ a lot of bug fixing, refactoring
❗ It will require regenerating prettyPrint tests in Fastify. Mostly because of bug fixing.
cc @climba03003 @Eomm @mcollina