Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for #25 #26

Merged
merged 2 commits into from
Jun 30, 2021
Merged

PR for #25 #26

merged 2 commits into from
Jun 30, 2021

Conversation

hardillb
Copy link
Contributor

A PR to implement the changes mentioned in #25

delvedor
delvedor requested changes Jun 28, 2021
View reviewed changes
Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, sorry for the delay! The fix looks ok! Can you also update the test to ensure that we won't remove it in the future? Thanks!

@hardillb
Copy link
Contributor Author

Hi, I've added a test I think should cover it.

delvedor
delvedor approved these changes Jun 29, 2021
View reviewed changes
Copy link
Owner

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@delvedor delvedor merged commit 56fa7b8 into delvedor:master Jun 30, 2021
@renovate renovate bot mentioned this pull request Jun 30, 2021
Merged
1 task
@mojavelinux mojavelinux mentioned this pull request Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @delvedor