Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzing fixes #1231

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Fuzzing fixes #1231

merged 4 commits into from
Jan 9, 2024

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Jan 9, 2024

Fixes a collection of issues defined in #1123

@slundqui slundqui changed the title Fuzz fixes Fuzzing fixes Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a2cf397) 80.53% compared to head (6fce75e) 80.51%.

Files Patch % Lines
lib/hyperlogs/hyperlogs/json_encoder.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
- Coverage   80.53%   80.51%   -0.03%     
==========================================
  Files          94       94              
  Lines        5334     5337       +3     
==========================================
+ Hits         4296     4297       +1     
- Misses       1038     1040       +2     
Flag Coverage Δ
unittests 80.51% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though we should add a new TODO for randomly turning slippage tolerance on/off for each bot.

@slundqui slundqui merged commit d7604e1 into delvtech:main Jan 9, 2024
3 of 4 checks passed
@slundqui slundqui deleted the fuzz_fixes branch January 9, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants