Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better rollbar logging and path invariance test upgrades #1252

Merged
merged 9 commits into from
Jan 16, 2024

Conversation

slundqui
Copy link
Contributor

  1. Interactive hyperdrive has parameter that allows logs to rollbar
  2. Adding log level when crash reporting in interactive hyperdrive
  3. Path independence allows for failed paths, logging failures as info to rollbar
  4. Adds optional ticker to interactive hyperdrive crash reports
  5. Adds optional message prefix to rollbar logs
  6. Catching and printing unexpected errors in run all fuzz tests

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (881e38b) 81.03% compared to head (04cc04d) 80.98%.

Files Patch % Lines
lib/hyperlogs/hyperlogs/rollbar_utilities.py 20.00% 8 Missing ⚠️
...0/hyperdrive/interactive/interactive_hyperdrive.py 80.00% 3 Missing ⚠️
...nt0/agent0/hyperdrive/crash_report/crash_report.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
- Coverage   81.03%   80.98%   -0.06%     
==========================================
  Files          94       94              
  Lines        5353     5370      +17     
==========================================
+ Hits         4338     4349      +11     
- Misses       1015     1021       +6     
Flag Coverage Δ
unittests 80.98% <53.84%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@slundqui slundqui force-pushed the fuzz-error-catching branch from 1cb755f to 04cc04d Compare January 16, 2024 21:28
@slundqui slundqui merged commit 6f7b1a3 into delvtech:main Jan 16, 2024
3 of 4 checks passed
@slundqui slundqui deleted the fuzz-error-catching branch January 16, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants