Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add calc_targeted_long and calc_spot_price_after_short #1413

Merged
merged 8 commits into from
Apr 18, 2024
Merged

add calc_targeted_long and calc_spot_price_after_short #1413

merged 8 commits into from
Apr 18, 2024

Conversation

dpaiton
Copy link
Member

@dpaiton dpaiton commented Apr 16, 2024 •
edited
Loading

  • add calc_targeted_long and calc_spot_price_after_short from rust
  • rename some variables & reorders functions to more closely match rust
  • reorganize & improve interface tests

@dpaiton dpaiton marked this pull request as draft April 16, 2024 17:27
@dpaiton dpaiton force-pushed the dpaiton/fixup-hyperdrivepy branch from 1fa81f0 to efb9b10 Compare April 17, 2024 22:22
@dpaiton dpaiton changed the title add and fix endpoints for hyperdrivepy add calc_targeted_long Apr 17, 2024
@dpaiton dpaiton changed the title add calc_targeted_long add calc_targeted_long and calc_spot_price_after_short Apr 17, 2024
@dpaiton dpaiton marked this pull request as ready for review April 17, 2024 23:38
wakamex
wakamex approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@wakamex wakamex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can create an issue to create calc_bond_reserves (not initial) later

@dpaiton dpaiton force-pushed the dpaiton/fixup-hyperdrivepy branch from edbe620 to 93a4bd5 Compare April 18, 2024 02:20
@dpaiton dpaiton force-pushed the dpaiton/fixup-hyperdrivepy branch from 8c6c878 to 3f2a8d7 Compare April 18, 2024 02:24
@dpaiton dpaiton merged commit 090071b into main Apr 18, 2024
3 checks passed
@dpaiton dpaiton deleted the dpaiton/fixup-hyperdrivepy branch April 18, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wakamex wakamex wakamex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpaiton @wakamex