Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Hyperdrive upgrade to v0.2.0 #26

Merged
merged 15 commits into from
Nov 8, 2023
Merged

Hyperdrive upgrade to v0.2.0 #26

merged 15 commits into from
Nov 8, 2023

Conversation

slundqui
Copy link
Contributor

@slundqui slundqui commented Nov 7, 2023

No description provided.

@slundqui slundqui changed the title Hyperdrive upgrade Hyperdrive upgrade to v0.2.0 Nov 7, 2023
@slundqui slundqui requested a review from dpaiton November 7, 2023 19:57
@slundqui slundqui marked this pull request as ready for review November 7, 2023 22:26
@dpaiton
Copy link
Member

dpaiton commented Nov 8, 2023 •
edited
Loading

I noticed you removed get_out_for_in and get_in_for_out and the safe variants. I don't think we're using that, but I'm wondering what the motivation was? Did this change in hyperdrive-rs?

edit: I see -- so instead of having the optional shares_in and shares_out boolean they have explicit functions now?

dpaiton
dpaiton approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, with some minor questions. Let's wait for @ryangoree to have a chance to commit any required wasm updates before we tick up the version to 0.2.0.

@dpaiton dpaiton mentioned this pull request Nov 8, 2023
Closed
@slundqui slundqui merged commit c36ac2a into main Nov 8, 2023
7 checks passed
@slundqui slundqui deleted the hyperdrive_upgrade branch November 8, 2023 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dpaiton dpaiton dpaiton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slundqui @dpaiton