Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hyperdrive-wasm into repo #1026

Merged
merged 14 commits into from
May 1, 2024
Merged

Move hyperdrive-wasm into repo #1026

merged 14 commits into from
May 1, 2024

Conversation

ryangoree
Copy link
Member

@ryangoree ryangoree commented May 1, 2024

This PR moves the rust crate for building @delvtech/hyperdrive-wasm into the repo to live close to the code that uses it.

To ensure the rust crate's Cargo.toml remains the single source of truth for the package manifest info, including it's version, the actual built wasm package has been gitignored. Then, to ensure that packages in the monorepo use the local build of @delvtech/hyperdrive-wasm instead of installing it from NPM, a preinstall hook has been added that will build the package from source if it doesn't already exist before installing dependencies.

This also means that the package has a different release flow then the typical yarn changeset. The release guidance in the README has been updated to reflect this.

Related to delvtech/hyperdrive-bindings#103

Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: 978d2c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-monorepo-hyperdrive-trading ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 6:41pm
hyperdrive-sepolia-production ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 6:41pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 6:41pm
trading-competition 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 1, 2024 6:41pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 6:41pm

@ryangoree ryangoree merged commit c391154 into main May 1, 2024
13 checks passed
@ryangoree ryangoree deleted the ryan-wasm branch May 1, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants